Constify conversion traits (part 1) #145279
Conversation
rustbot
added
S-waiting-on-review
| #![feature(const_default)] | ||
| #![feature(const_eval_select)] | ||
| #![feature(const_heap)] | ||
| #![feature(const_trait_impl)] |
There was a problem hiding this comment.
Was listed under library features, and is actually a language feature. Since the diff doesn't make that clear.
| // FIXME(const-hack): this should use map_err instead | ||
| match u8::try_from(u32::from(c)) { | ||
| Ok(b) => Ok(b), | ||
| Err(_) => Err(TryFromCharError(())), | ||
| } |
There was a problem hiding this comment.
You mentioned not wanting to add any more const-hacks, but I figured this one (+ for u16 below) was okay because we're already going to have to fix a lot of const code once things are stable, and I think that simple char <-> integer conversions are useful enough to get on nightly sooner. Especially since const closures seem pretty far off at the moment.
|
☔ The latest upstream changes (presumably #145334) made this pull request unmergeable. Please resolve the merge conflicts. |
clarfonthey
force-pushed
the
const-convert-initial
branch
from
365fcde to
97c330f
Compare
|
Rebasing over #144847 since that one conflicts with this one, which is why I was going to do this one before I got to that one, but, it's in the queue now, so, 🤷🏻. Only changes with the rebase are eliminating more additions of |
clarfonthey
force-pushed
the
const-convert-initial
branch
from
97c330f to
4ebb4b7
Compare
|
This PR was rebased onto a different master commit! Check out the changes with our |
|
☔ The latest upstream changes (presumably #145644) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Will rebase once that PR gets merged. I can mark it as blocked, but it still can be reviewed before to verify you're comfortable with the changes. |
clarfonthey
force-pushed
the
const-convert-initial
branch
from
4ebb4b7 to
4bcf7bd
Compare
This comment has been minimized.
This comment has been minimized.
|
(Un-rebased over that PR since it's no longer in the queue.) |
…oshtriplett `const`ify (the unstable) `str::as_str` Tracking issue: rust-lang#130366 The method was not initially marked `const` presumably because it is only useful with `Deref`. But now that const traits seem to be a thing that can actually become real, why not make it `const`? PR `const`ifying `Deref`: rust-lang#145279
Rollup merge of #145930 - GrigorenkoPV:const_str_as_str, r=joshtriplett `const`ify (the unstable) `str::as_str` Tracking issue: #130366 The method was not initially marked `const` presumably because it is only useful with `Deref`. But now that const traits seem to be a thing that can actually become real, why not make it `const`? PR `const`ifying `Deref`: #145279
clarfonthey
force-pushed
the
const-convert-initial
branch
from
4bcf7bd to
66dcd76
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
const-convert-initial
branch
from
66dcd76 to
636cfe4
Compare
clarfonthey
force-pushed
the
const-convert-initial
branch
from
636cfe4 to
1c64d3e
Compare
|
Incorporated the methods from #146101 and listed them in the issue description. |
This is the first part of #144289 being split into smaller pieces. It adds/moves constness of several traits under the
const_convertfeature:FromIntoTryFromTryIntoFromStrAsRefAsMutBorrowBorrowMutDerefDerefMutThere are a few methods that are intrinsically tied to these traits which I've included in the feature. Particularly, those which are wrappers over
AsRef:ByteStr::new(unstable underbstrfeature)OsStr::newPath::newThose which directly use
Into:Result::into_okResult::into_errAnd those which use
DerefandDerefMut:Pin::as_refPin::as_mutPin::as_deref_mutOption::as_derefOption::as_deref_mutResult::as_derefResult::as_deref_mut(note: the
OptionandResultmethods were suggested by @npmccallum initially as #146101)The parts which are missing from this PR are:
OsStrorPath(note: this mostly makes these methods useless sincestrdoesn't implementAsRef<OsStr>yet, but it's better to track the method for now and add impls later, IMHO)r? @tgross35 (who mostly already reviewed this)